Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Revert default l0 forward policy to FilterByBF #37867

Merged
merged 2 commits into from
Nov 22, 2024
Merged

enhance: Revert default l0 forward policy to FilterByBF #37867

merged 2 commits into from
Nov 22, 2024

Conversation

congqixia
Copy link
Contributor

Related to #37767

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 21, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

czs007
czs007 reviewed Nov 21, 2024
View reviewed changes
configs/milvus.yaml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@5f3601a). Learn more about missing BASE report.
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37867   +/-   ##
=========================================
  Coverage          ?   81.05%           
=========================================
  Files             ?     1357           
  Lines             ?   190393           
  Branches          ?        0           
=========================================
  Hits              ?   154319           
  Misses            ?    30600           
  Partials          ?     5474
Components Coverage Δ
Client 72.16% <ø> (?)
Core 68.87% <ø> (?)
Go 83.22% <100.00%> (?)
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.35% <100.00%> (ø)
---- 🚨 Try these New Features:

@czs007 czs007 mentioned this pull request Nov 21, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@congqixia congqixia force-pushed the revert/default_l0_foward_policy branch from 2f41ea1 to b9d2bee Compare November 21, 2024 14:20
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 22, 2024
@sre-ci-robot sre-ci-robot merged commit 83df725 into milvus-io:master Nov 22, 2024
20 checks passed
@congqixia congqixia deleted the revert/default_l0_foward_policy branch November 22, 2024 03:00
sre-ci-robot pushed a commit that referenced this pull request Nov 22, 2024
@czs007
fix: Revert "enhance: [2.4] Enable RemoteLoad l0 forward policy" (#…
9b3de3a 
…37875)

issue #35303
pr: #37867
This reverts commit cdf703a.

Signed-off-by: zhenshan.cao <[email protected]>
@xiaocai2333 xiaocai2333 mentioned this pull request Nov 22, 2024
Open
1 task
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
@congqixia @JsDove
enhance: Revert default l0 forward policy to FilterByBF (milvus-io#37867
0f8e83e 
)

Related to milvus-io#37767

---------

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@congqixia @xiaofan-luan @sre-ci-robot @czs007